feat: allow for config of which CLI to use#58
Conversation
scripts/download.sh
Outdated
| fi | ||
| CODECOV_COMMAND="codecovcli" | ||
|
|
||
| CODECOV_COMMAND="${CODECOV_CLI_TYPE}cli" |
There was a problem hiding this comment.
can we consider having these things be the same name (e.g. pip install codecov-cli and codecov-cli be the command?
probably out of scope, but wanted to bring this up
There was a problem hiding this comment.
Also note that the executable name we settled on for prevent is sentry-prevent-cli
scripts/download.sh
Outdated
| [[ $CODECOV_OS == "windows" ]] && CODECOV_FILENAME+=".exe" | ||
| CODECOV_COMMAND="./$CODECOV_FILENAME" | ||
| CODECOV_FILENAME="${CODECOV_CLI_TYPE}" | ||
| [[ $CODECOV_OS == "windows" ]] && codecov_filename+=".exe" |
There was a problem hiding this comment.
please keep these capitalized or the orb will freak out
scripts/set_defaults.sh
Outdated
| $r Wrapper-$CODECOV_WRAPPER_VERSION$x | ||
| " | ||
|
|
||
| CODECOV_CLI_TYPE=${CODECOV_CLI_TYPE:-"codecov"} |
There was a problem hiding this comment.
can move this higher up in the chain before the header is printed
dist/codecov.sh
Outdated
| " | ||
| CODECOV_CLI_TYPE=${CODECOV_CLI_TYPE:-"codecov"} | ||
| if [[ "$CODECOV_CLI_TYPE" != "codecov" && "$CODECOV_CLI_TYPE" != "prevent" ]]; then | ||
| echo "Invalid CODECOV_CLI_TYPE: '$CODECOV_CLI_TYPE'. Must be 'codecov' or 'prevent'" |
There was a problem hiding this comment.
see my response down below. prevent won't work I don't think?
| CODECOV_VERSION="${CODECOV_VERSION:-latest}" | ||
| CODECOV_FAIL_ON_ERROR="${CODECOV_FAIL_ON_ERROR:-false}" | ||
| CODECOV_RUN_CMD="${CODECOV_RUN_CMD:-upload-coverage}" | ||
| CODECOV_CLI_TYPE=${CODECOV_CLI_TYPE:-"codecov-cli"} |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 2 2
Lines 35 35
=======================================
Hits 34 34
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 participants
No description provided.